app/gosqs: increment number of receives for a message #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When returning an SQS message, increment the 'NumberOfReceives' so it
always contains the number of times a message has been received but not
yet deleted.
From the AWS SQS docs:
ApproximateReceiveCount – Returns the number of times a message has been received across all queues but not deleted.
|
@vishen Sorry it's been such a long time - this looks great to me. Mind throwing a test in here for it? |
Admiral-Piett
force-pushed
the
master
branch
from
cc2c103
to
a43d9fd
Compare
|
@vishen Following up here - if you don't want to mess with this anymore (understandable) I'll branch off this, write some tests and merge that instead. Let me know! I appreciate the effort! |
|
Apologies @Admiral-Piett , I don't have the time anymore to add the tests. If you have time to add them that would be amazing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning an SQS message, increment the 'NumberOfReceives' so it
always contains the number of times a message has been received but not
yet deleted.
From the AWS SQS docs: