Refactor MessageAttributes #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admiral-Piett
commented
Oct 31, 2024
| StringValue string `json:"StringValue,omitempty"` | ||
| type MessageAttribute struct { | ||
| BinaryListValues []string `json:"BinaryListValues,omitempty" xml:"BinaryListValues,omitempty"` // currently unsupported by AWS | ||
| BinaryValue []byte `json:"BinaryValue,omitempty" xml:"BinaryValue,omitempty"` |
There was a problem hiding this comment.
@kojisaikiAtSony So, this PR is some significant work toward normalizing the MessageAttributes as we previously discussed. I think this piece specifically will solve your issue in #330. There's a lot of other overhaul here though I know.
What do you think? I can build it for you first if you'd like to test it before hand and make sure it works for your use cases. Let me know!
There was a problem hiding this comment.
Great! We'll check this work is able to be alternative with #330!
kojisaikiAtSony
approved these changes
Nov 1, 2024
|
@Admiral-Piett It looks good and it works on our app with latest AWS SDK for Java! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.