Received Message Attribute via XML is not decoded from base 64 #343
+103
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [a52b572] added base 64 deconde on publish
kojisaikiAtSony
commented
Jan 14, 2025
| @@ -370,7 +372,7 @@ func TestSendMessageBatchV1_Xml_Success_including_attributes(t *testing.T) { | |||
| WithFormField("Entries.1.MessageBody", messageBody2). | |||
| WithFormField("Entries.1.MessageAttributes.1.Name", binaryAttributeKey). | |||
| WithFormField("Entries.1.MessageAttributes.1.Value.DataType", binaryType). | |||
| WithFormField("Entries.1.MessageAttributes.1.Value.BinaryValue", binaryValue). | |||
| WithFormField("Entries.1.MessageAttributes.1.Value.BinaryValue", binaryValueEncodeString). | |||
There was a problem hiding this comment.
Here is for blobs are sent and received after being base64 encoded.
BinaryValue in XML should be base 64 encoded.
|
Hi @Admiral-Piett , can you please review this? This is the last piece to update our AWS SDK version... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
JSON requests has decoded from base 64 on JSON marshaller, but for XML, the
SetAttributesFromFormdoes not have decoding step. So internal BinaryValue was still base 64 string (as binary) value.This is a part of XML protocol, but today the actual AWS SNS and the SDK for SNS is still using XML whereas SQS has already moved to SQS (#337). We have acknowledged that by our investigation and lack of JSON description on official SNS doc. This blocks tests that use SNS apis.
Fix:
Add base 64 decoding step in
SetAttributesFromForm.