Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note Regarding View Config and Emails #73

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pykettk
Copy link
Contributor

@pykettk pykettk commented Dec 20, 2022

Description

Adds a note regarding how etc/view.xml configurations are applied to emails during area emulation.

Affected page: https://developer.adobe.com/commerce/frontend-core/guide/themes/configure/

Motivation and Context

This information does not appear to be documented anywhere and developers will waste time trying to figure out why their theme configuration is not being applied in some scenarios - see magento/magento2 issue#36340.

How Has This Been Tested?

  1. Put product out of stock
  2. Run relevant indexers
  3. Register for a stock alert for the product from step 1
  4. Run the product_alert queue consumer
  5. Observe that only etc/view.xml configurations defined in modules are loaded in Magento\Framework\Config\View::read()

Types of changes

  • Documentation update

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meker12 meker12 requested review from jeff-matthews and removed request for jeff-matthews January 19, 2023 18:36
@jeff-matthews jeff-matthews self-assigned this Feb 23, 2023
@jeff-matthews jeff-matthews added the technical Updates to the code or processes that alter the technical content of the doc label Feb 23, 2023
@jeff-matthews jeff-matthews self-requested a review February 23, 2023 19:47
@jeff-matthews
Copy link
Contributor

Thanks for the contribution and sorry about the delay on this @pykettk. I'm verifying your changes now.

@keharper
Copy link
Contributor

keharper commented Jun 8, 2023

@jeff-matthews Did you find someone to verify this PR?

@jeff-matthews
Copy link
Contributor

Yes, but I never heard back. I'll have to find someone else after the June release.

@dobooth
Copy link
Contributor

dobooth commented Jul 20, 2023

Closing as abandoned. Please reopen when ready.

@dobooth dobooth closed this Jul 20, 2023
@dobooth
Copy link
Contributor

dobooth commented Jul 20, 2023

Closed by error.

@dobooth dobooth reopened this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Updates to the code or processes that alter the technical content of the doc
Projects
Status: 🧑‍💻 In Progress
Development

Successfully merging this pull request may close these issues.

4 participants