generated from AdobeDocs/dev-site-documentation-template
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Note Regarding View Config and Emails #73
Open
pykettk
wants to merge
4
commits into
AdobeDocs:main
Choose a base branch
from
pykettk:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution and sorry about the delay on this @pykettk. I'm verifying your changes now. |
@jeff-matthews Did you find someone to verify this PR? |
Yes, but I never heard back. I'll have to find someone else after the June release. |
Closing as abandoned. Please reopen when ready. |
Closed by error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a note regarding how
etc/view.xml
configurations are applied to emails during area emulation.Affected page: https://developer.adobe.com/commerce/frontend-core/guide/themes/configure/
Motivation and Context
This information does not appear to be documented anywhere and developers will waste time trying to figure out why their theme configuration is not being applied in some scenarios - see magento/magento2 issue#36340.
How Has This Been Tested?
product_alert
queue consumeretc/view.xml
configurations defined in modules are loaded inMagento\Framework\Config\View::read()
Types of changes
Checklist: