-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Windows Subsystem for Linux #21
base: master
Are you sure you want to change the base?
Conversation
GitHub actions revised
Revert "GitHub actions revised"
@pklaschka looks like the commits for #35 ended up on this PR (I assume accidentally? 😄) |
@ashryanbeats And we now have a discussion in two places about this 😆 See my response in #35 😉 |
I've therefore reverted the merge in my master to not make this thing more complicated than it already is 🙂 |
@pklaschka @ashryanbeats Does it any reasons to support Linux based platforms if Adobe XD doesn't? |
Hi @alexandrtovmach, I believe Pablo addressed this in the original PR:
So it's not a question of Linux support, per se. Is there further detail you'd need? |
@alexandrtovmach There is the "Windows subsystem for Linux", which allows using a UNIX Shell in Windows (which makes development so much more enjoyable). Plus, development can be done on any platform. Personally, I develop on another machine (running Linux) and test on multiple machines (Windows, macOS). Therefore, while more of an edge-case, it does make sense to at least not "artificially prohibit" Linux-based platforms 😉. While I use my own, network-based xdpm-like solution for installing plugins on test machines during development (https://github.com/pklaschka/xd-deploy), I still use xdpm to build the plugins and do some development on my Windows laptop if I have to (e.g., when I'm traveling), meaning supporting WSL, for me, makes it much more enjoyable to use. |
@pklaschka Okay, now I see the case and it sounds reasonable 👍 @ashryanbeats Yeah, thanks for clarifying. I was confused with |
While this may be more of an edge case, at least for me, it's useful to have support for the Windows Subsystem for Linux (providing me with a nicer shell to work with).
I've not tested if this breaks
xdpm
for other platforms, which is why for now I'll open this as a draft pull request, but if more people than just me are interested in this, I'd be willing to work on getting this "production-ready" to get merged here...For now, it's just a bunch of crappy code, trying to get it to work (extracting the relevant paths in the subsystem is relatively difficult, so please excuse the "not-so-ideal" code)...