-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/response variable unification #162 #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chaen-ing
merged 7 commits into
develop
from
refactor/response-variable-unification-#162
Jul 20, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d506828
Refactor: ์์ฐ๋ ์ปจํธ๋กค๋ฌ swagger์์ ์ ์ธ (#162)
chaen-ing 7d5bb56
Refactor: swagger ์ ๋ ฌ (#162)
chaen-ing 6b97c70
Refactor: swagger ์๋ฒ ์ฐ๊ฒฐ ์ ๋ฆฌ (#162)
chaen-ing 298fb72
Refactor: seed๊ด๋ จ ๋ณ์๋ช
์ ๋ฆฌ (#162)
chaen-ing 9ee3be3
Refactor: tag, category๋ง ์์ (#162)
chaen-ing 5f42866
Refactor: request์์ (#162)
chaen-ing 8a218c9
Refactor: rename tagNames to tags in SeedFilteringRequest (#162)
chaen-ing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 45 additions & 36 deletions
81
src/main/java/com/adoonge/seedzip/seed/dto/response/SeedResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,55 @@ | ||
| package com.adoonge.seedzip.seed.dto.response; | ||
|
|
||
| import com.adoonge.seedzip.seed.domain.SeedType; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
|
|
||
| import lombok.Builder; | ||
|
|
||
| public class SeedResponse { | ||
|
|
||
| @Builder | ||
| public record PageInfo(int page, int size, int totalPages, long totalElements, boolean isLast) {} | ||
|
|
||
| @Builder | ||
| public record SeedInfo(Long seedId, String seedName, List<Long> categoryId, List<String> categoryName, | ||
| SeedType seedType, String thumbnailImage, LocalDateTime updatedDt, | ||
| List<Long> tagId, List<String> tagName, int dDay, Boolean isSaved) {} | ||
|
|
||
| @Builder | ||
| public record GetAllSeeds(String nickname, List<SeedInfo> seedInfoList, PageInfo pageInfo) {} | ||
|
|
||
| @Builder | ||
| public record SeedInfoSimple(Long seedId, String seedName){} | ||
|
|
||
| @Builder | ||
| public record SeedDetail(Long seedId, | ||
| SeedType seedType, | ||
| String seedName, | ||
| String seedLink, | ||
| List<String> fileLinks, | ||
| List<String> titles, | ||
| Long thumbnailImage, | ||
| List<String> categoryNames, | ||
| List<String> tagNames, | ||
| LocalDate dDay, | ||
| String seedDetail){} | ||
|
|
||
| @Builder | ||
| public record SeedInfoWithSeedDetail( | ||
| Long seedId, String seedName, List<Long> categoryId, List<String> categoryName, | ||
| SeedType seedType, String thumbnailImage, LocalDateTime updatedDt, | ||
| List<Long> tagId, List<String> tagName, int dDay, String seedDetail, Boolean isSaved | ||
| ){} | ||
|
|
||
| @Builder | ||
| public record GetFilteredSeeds(String nickname, List<SeedInfoWithSeedDetail> seedInfoList, PageInfo pageInfo){} | ||
| @Builder | ||
| public record PageInfo(int page, int size, int totalPages, long totalElements, boolean isLast) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record SeedInfo(Long seedId, String seedName, List<Long> categoryId, List<String> categoryName, | ||
| SeedType seedType, String thumbnailImage, LocalDateTime updatedDt, | ||
| List<Long> tagId, List<String> tagName, int dDay, Boolean isSaved) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record GetAllSeeds(String nickname, List<SeedInfo> seedInfoList, PageInfo pageInfo) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record SeedInfoSimple(Long seedId, String seedName) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record SeedDetail(Long seedId, | ||
| SeedType seedType, | ||
| String seedName, | ||
| String seedLink, | ||
| List<String> fileLinks, | ||
| List<String> titles, | ||
| Long thumbnailImage, | ||
| List<String> categoryName, | ||
| List<String> tagName, | ||
| LocalDate dDay, | ||
| String seedDetail) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record SeedInfoWithSeedDetail( | ||
| Long seedId, String seedName, List<Long> categoryId, List<String> categoryName, | ||
| SeedType seedType, String thumbnailImage, LocalDateTime updatedDt, | ||
| List<Long> tagId, List<String> tagName, int dDay, String seedDetail, Boolean isSaved) { | ||
| } | ||
|
|
||
| @Builder | ||
| public record GetFilteredSeeds(String nickname, List<SeedInfoWithSeedDetail> seedInfoList, PageInfo pageInfo) { | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a substring check to detect localhost URLs is brittle; consider relying on an explicit environment/profile flag or parsing the URL scheme so you can handle various formats and avoid accidental mismatches.