Skip to content

Conversation

@gyuseon25
Copy link
Member

🪺 Summary

앱용 씨드 수정 API 구현 완료했습니다!
기존 씨드 수정 API에서 파일 삭제나 링크 수정 부분을 제거했습니다!

🌱 Issue Number

🙏 To Reviewers

@gyuseon25 gyuseon25 self-assigned this Oct 16, 2025
@gyuseon25 gyuseon25 added the Refactor ♻️ 코드 리팩토링 label Oct 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new app-specific seed update API that provides a simplified version of the existing seed update functionality. The main difference is that file deletion and link modification capabilities have been removed to suit mobile app requirements.

Key Changes:

  • Added SeedUpdateRequestForApp DTO with validation for app-specific seed updates
  • Implemented updateSeedForApp service method that excludes file and link modifications
  • Created new PATCH endpoint /app/{seedId} for mobile app seed updates

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
SeedUpdateRequestForApp.java New DTO record for app-specific seed update requests with validation constraints
SeedService.java New service method updateSeedForApp implementing simplified update logic without file/link modifications
SeedController.java New PATCH endpoint exposing the app-specific seed update functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

public record SeedUpdateRequestForApp(
@NotNull SeedType seedType,
String seedName, // 제목 (없으면 null)
@NotNull String[] categoryName, // 카테고리 (없으면 null)
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is marked as @NotNull but the comment states it can be null ('없으면 null'). Remove @NotNull if null values are acceptable, or update the comment to reflect that this field is required.

Suggested change
@NotNull String[] categoryName, // 카테고리 (없으면 null)
String[] categoryName, // 카테고리 (없으면 null)

Copilot uses AI. Check for mistakes.
Comment on lines 4 to +5
import com.adoonge.seedzip.seed.dto.request.SeedDeleteListRequest;
import com.adoonge.seedzip.seed.dto.request.SeedFilteringRequest;
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequest;
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequestForApp;
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Import statements are not in alphabetical order. SeedUpdateRequestForApp should come after SeedUpdateRequest to maintain consistency and readability.

Suggested change
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequest;
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequestForApp;
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequestForApp;
import com.adoonge.seedzip.seed.dto.request.SeedUpdateRequest;

Copilot uses AI. Check for mistakes.
@gyuseon25 gyuseon25 merged commit 5ac1dfd into develop Oct 16, 2025
1 check passed
@chaen-ing chaen-ing deleted the refactor/app-seed-patch-#173 branch January 3, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor ♻️ 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants