Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding User input #121

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding User input #121

wants to merge 3 commits into from

Conversation

Antsalacia
Copy link
Collaborator

@Antsalacia Antsalacia commented Dec 9, 2024

Add user input as a string

closes #56

@AdrienWehrle
Copy link
Owner

AdrienWehrle commented Dec 12, 2024

Thanks for working on this @Antsalacia ! I think we can just put the tag at the end of the mosaic tif file and not every single split box. So it would only be needed here (and not where you put it for now):

earthspy/earthspy/earthspy.py

Lines 1049 to 1052 in f0ae4f7

date_output_filename = date_response_files[0].replace(
"_0.tif",
"_SM_mosaic.tif",
)

@AdrienWehrle
Copy link
Owner

Thanks for working on this @Antsalacia ! Now we need a default label in case the user doesn't pass one. Any ideas?

@Antsalacia
Copy link
Collaborator Author

We could add default ?

@AdrienWehrle
Copy link
Owner

We could add default ?

I think the point here would be to have a different label for different areas running on the same date so that they don't get replaced. Having default would just change the file name but still overwrite.

Maybe a tag like lat{latitude}_lon{longitude} could make sense, where latitude and longitude is the center point of the bounding box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve file naming to prevent overwrite
2 participants