Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #11

Merged
merged 4 commits into from
Aug 7, 2021
Merged

Conversation

Devanshu24
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #11 (24a07a2) into main (09d01a5) will decrease coverage by 64.71%.
The diff coverage is 53.84%.

@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   96.96%   32.25%   -64.72%     
===========================================
  Files           7        7               
  Lines          33       93       +60     
===========================================
- Hits           32       30        -2     
- Misses          1       63       +62     
Impacted Files Coverage Δ
code_soup/ch5/mnist_gan.py 0.00% <0.00%> (ø)
code_soup/ch5/models/discriminator.py 100.00% <ø> (ø)
code_soup/ch5/models/generator.py 100.00% <ø> (ø)
code_soup/ch5/__init__.py 100.00% <100.00%> (ø)
code_soup/ch5/datasets/__init__.py 100.00% <100.00%> (ø)
code_soup/ch5/datasets/mnist.py 100.00% <100.00%> (ø)
code_soup/ch5/models/__init__.py 100.00% <100.00%> (ø)

@Devanshu24
Copy link
Contributor Author

The imports don't work as I've changed them to absolute imports, and some things broke.
Working on it.

@someshsingh22 someshsingh22 linked an issue Aug 7, 2021 that may be closed by this pull request
12 tasks
@Devanshu24
Copy link
Contributor Author

@someshsingh22 Have a look, coverage is failing but rest seems fine.
I'll remove the redundant python versions in a separate PR

Copy link
Member

@someshsingh22 someshsingh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, Coverage we can improve in the GAN PR

@someshsingh22 someshsingh22 linked an issue Aug 7, 2021 that may be closed by this pull request
@someshsingh22 someshsingh22 merged commit 9cc5627 into Adversarial-Deep-Learning:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeCoverage Report Missing
2 participants