Skip to content

Add MNIST GAN #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 7, 2021
Merged

Add MNIST GAN #8

merged 11 commits into from
Aug 7, 2021
+450 −138

Conversation

harsh4799
Copy link
Member

No description provided.

@someshsingh22
Copy link
Member

@blackrosedragon2 Who is taking the tests up? They should be there before the implementation right

@someshsingh22
Copy link
Member

Also, can you rename chapter 1 to be chapter 5?

@someshsingh22 someshsingh22 self-assigned this Aug 6, 2021
@someshsingh22 someshsingh22 linked an issue Aug 6, 2021 that may be closed by this pull request
Implement Generative Adversarial Networks (GANs) #1
Closed
12 tasks
someshsingh22
someshsingh22 requested changes Aug 6, 2021
View reviewed changes
Copy link
Member

@someshsingh22 someshsingh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Visualisation will be added in Tutorials so it is not needed here, you can save it for a future tutorial issue
  2. Rename To chapter 5 (Its chapter 1 right now)
  3. There are no unit tests right now, unit tests will be needed for all modules for a 100% coverage

@codecov
Copy link

codecov bot commented Aug 7, 2021 •
edited
Loading

Codecov Report

Merging #8 (10be06e) into main (879cc7f) will not change coverage.
The diff coverage is n/a.

❗ Current head 10be06e differs from pull request most recent head efa126b. Consider uploading reports for the commit efa126b to get more accurate results

@@    Coverage Diff    @@
##   main   #8   +/-   ##
=========================
=========================

@someshsingh22 someshsingh22 mentioned this pull request Aug 7, 2021
Merged
@someshsingh22 someshsingh22 merged commit b49ef20 into Adversarial-Deep-Learning:main Aug 7, 2021
@someshsingh22
Copy link
Member

Merging this PR if any issues arise during code coverage new issue will be opened!
Great work @blackrosedragon2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@someshsingh22 someshsingh22

Assignees

@someshsingh22 someshsingh22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Generative Adversarial Networks (GANs)
2 participants
@harsh4799 @someshsingh22