Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPT-57] Home: Standardise vertical alignment of content #703

Closed
wants to merge 7 commits into from

Conversation

Unknownflow
Copy link
Contributor

I aligned the headers of the content so they are in line with each other

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for tender-meitner-99286b ready!

Name Link
🔨 Latest commit 31700f8
🔍 Latest deploy log https://app.netlify.com/sites/tender-meitner-99286b/deploys/664426c0301b7600089e8615
😎 Deploy Preview https://deploy-preview-703--tender-meitner-99286b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90
Accessibility: 95
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Unknownflow Unknownflow self-assigned this Jan 22, 2024
@Unknownflow Unknownflow linked an issue Jan 22, 2024 that may be closed by this pull request
@wei2912 wei2912 requested review from a team and nicholasohjj and removed request for a team January 23, 2024 04:15
Copy link

@nicholasohjj nicholasohjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vertical alignment fixed.

Mentor tab needs padding and margin from top of the card. Reduce border radius.

Avatar image should be shifted to the left to align with testimonial titles.

More padding between avatar image and right text content.

Consider align left for name + tag, an
Uploading image.png…
d title to align with quote.

@wei2912
Copy link
Member

wei2912 commented Feb 4, 2024

To be routed to @jcc-kh for final verdict on design, after @nicholasohjj clarifies feedback above with @Unknownflow.

@wei2912 wei2912 requested a review from jcc-kh February 16, 2024 14:15
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Unknownflow See below comment from @jcc-kh:

Is it possible to have the words 'Managing Director' and 'Persistensie Pte Ltd' on the same line? Right now it's too sparse it looks a bit weird

@jcc-kh
Copy link

jcc-kh commented Mar 11, 2024

@Unknownflow can attach the updated screenshot of the page here for review

@Unknownflow
Copy link
Contributor Author

image
I have attached the image of the page where the words 'Managing Director' and 'Persistensie Pte Ltd' are on the same line.

@wei2912 wei2912 marked this pull request as draft April 5, 2024 15:01
@wei2912
Copy link
Member

wei2912 commented Apr 5, 2024

Think having them directly side-by-side would impact readability, @jcc-kh do you have suggestions for how they can be arranged on the same line (keeping in mind that the design should work on mobile too)?

@wei2912 wei2912 marked this pull request as ready for review April 5, 2024 15:03
@jcc-kh
Copy link

jcc-kh commented May 1, 2024

HM, add a comma in between the words? HAHA I think that's how people do it?
image

@Unknownflow
Copy link
Contributor Author

I have added a comma between the words, in this case it is between the mentor role and company as shown below.

image

@wei2912
Copy link
Member

wei2912 commented Jun 2, 2024

Sorry, think I neglected to get this merged in before working on 3cd8463... will take over the PR.

@wei2912 wei2912 self-assigned this Jun 2, 2024
@wei2912 wei2912 marked this pull request as draft June 2, 2024 10:13
@wei2912 wei2912 requested a review from Hackin7 June 6, 2024 06:19
@wei2912
Copy link
Member

wei2912 commented Jun 6, 2024

@Hackin7 Handing over to you in case any of the code here is relevant to the latest version.

wei2912 added a commit that referenced this pull request Jul 7, 2024
Closes MPT-57 (#692)
and supersedes #703.
@wei2912
Copy link
Member

wei2912 commented Jul 7, 2024

Closing PR as it has been superseded by be7f563, and was previously made outdated by 3cd8463.

@wei2912 wei2912 closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPT-57] Home: Standardise vertical alignment of content
4 participants