#63 delete obsolete additionalData from payment response which is s…

…tore… (#97) * delete obsolete `additionalData` from payment response which is stored in interfaceInteractions.fields. * fix typo exists to exist.
Adyen · Dec 19, 2019 · 9228336 · 9228336
1 parent 77f9cba
commit 9228336
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 0 deletions.
diff --git a/extension/src/paymentHandler/payment-utils.js b/extension/src/paymentHandler/payment-utils.js
@@ -62,6 +62,9 @@ function createAddInterfaceInteractionAction (
     request, response, type, status
   }
 ) {
+  // strip away sensitive data
+  delete response.additionalData
+
   return {
     action: 'addInterfaceInteraction',
     type: { key: c.CTP_INTERFACE_INTERACTION },

diff --git a/extension/test/integration/cancel-or-refund.handler.spec.js b/extension/test/integration/cancel-or-refund.handler.spec.js
@@ -57,5 +57,6 @@ describe('Cancel or refund', () => {
 
     const adyenResponse = JSON.parse(interfaceInteractionFields.response)
     expect(adyenResponse.response).to.equal('[cancelOrRefund-received]')
+    expect(adyenResponse.additionalData).to.not.exist
   })
 })
diff --git a/extension/test/integration/credit-card-make-payment.handler.spec.js b/extension/test/integration/credit-card-make-payment.handler.spec.js
@@ -49,6 +49,7 @@ describe('credit card payment', () => {
 
     const adyenResponse = JSON.parse(response.body.interfaceInteractions[0].fields.response)
     expect(adyenResponse.resultCode).to.be.equal('Authorised')
+    expect(adyenResponse.additionalData).to.not.exist
 
     const { transactions } = response.body
     expect(transactions).to.have.lengthOf(1)
@@ -91,6 +92,7 @@ describe('credit card payment', () => {
     expect(adyenResponse.redirect.data.MD).to.exist
     expect(adyenResponse.redirect.method).to.exist
     expect(adyenResponse.redirect.url).to.exist
+    expect(adyenResponse.additionalData).to.not.exist
   })
 
   it('on wrong credit card number, should log error to interface interaction', async () => {
@@ -128,6 +130,7 @@ describe('credit card payment', () => {
     expect(transaction.interactionId).to.be.undefined
     expect(transaction.type).to.equal('Authorization')
     expect(transaction.state).to.equal('Initial')
+    expect(adyenResponse.additionalData).to.not.exist
 
     const response2 = await ctpClient.update(ctpClient.builder.payments,
       ctpPayment.id, ctpPayment.version, [

diff --git a/extension/test/integration/fetch-payment-method.handler.spec.js b/extension/test/integration/fetch-payment-method.handler.spec.js
@@ -34,5 +34,6 @@ describe('fetch payment', () => {
     const adyenResponse = JSON.parse(interfaceInteractionFields.response)
     expect(adyenResponse.groups).to.be.an.instanceof(Array)
     expect(adyenResponse.paymentMethods).to.be.an.instanceof(Array)
+    expect(adyenResponse.additionalData).to.not.exist
   })
 })
diff --git a/extension/test/integration/kcp-make-payment.spec.js b/extension/test/integration/kcp-make-payment.spec.js
@@ -24,5 +24,10 @@ describe('kcp make payment', () => {
     expect(response.statusCode).to.equal(201)
     expect(response.body.custom.fields.redirectMethod).to.equal('GET')
     expect(response.body.custom.fields.redirectUrl).to.exist
+
+    const adyenResponse = JSON.parse(response.body.interfaceInteractions[0].fields.response)
+    expect(adyenResponse.redirect.method).to.exist
+    expect(adyenResponse.redirect.url).to.exist
+    expect(adyenResponse.additionalData).to.not.exist
   })
 })
diff --git a/extension/test/integration/paypal-redirect-shopper.handler.spec.js b/extension/test/integration/paypal-redirect-shopper.handler.spec.js
@@ -24,5 +24,10 @@ describe('Paypal payment', () => {
     expect(response.statusCode).to.equal(201)
     expect(response.body.custom.fields.redirectMethod).to.equal('GET')
     expect(response.body.custom.fields.redirectUrl).to.exist
+
+    const adyenResponse = JSON.parse(response.body.interfaceInteractions[0].fields.response)
+    expect(adyenResponse.redirect.method).to.exist
+    expect(adyenResponse.redirect.url).to.exist
+    expect(adyenResponse.additionalData).to.not.exist
   })
 })