Card type should be called scheme #65
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candemiralp
requested changes
Nov 4, 2024
| @@ -66,7 +66,7 @@ use Adyen\Hyva\Magewire\Payment\Method\CreditCard; | |||
| creditCardHandler.setCreditCardType(creditCardHandler.getCcCodeByAltCode(state.brand)); | |||
| }, | |||
| name: '<?= $escaper->escapeJs($magewire->getConfiguration()->getValue('adyenCc/title')) ?>', | |||
| type: "card", | |||
| type: "scheme", | |||
There was a problem hiding this comment.
This field is used for rendering Card Component and this type should be card. Please refer to configuration section v5.x.x or earlier on Card Component documentation.
| @@ -74,7 +74,7 @@ private function isMethodAvailable($method, $configuredKeys): bool | |||
| private function collectMethodCodeWithoutPrefix($methodCode): string | |||
| { | |||
| if ($methodCode == CreditCard::METHOD_CC) { | |||
| return 'card'; | |||
| return 'scheme'; | |||
There was a problem hiding this comment.
As paymentMethodsExtraDetails value has been used on line 46 in the same file, this value should stay as card. Because paymentMethodsExtraDetails returns key card for scheme payments in the Adyen_Payment module here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The credit-card payment method did not show up for me. It seems like that is because the response from /paymentMethods gives the cards with the 'scheme' type payment method.
It seems that the adyen-magento2 module has a map for this case here.
I also noticed that the test had a key for
paymentMethodsreturn. But in my case it did not return thepaymentMethodswith a key...Tested scenarios
Open checkout and see if the cards payment method shows up.
It didn't before now it does.
Fixes #66
Versions used