Make VaultMigration compatible with disabled/removed Magento PayPal module #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule **Issue** The installation/upgrade of the Adyen Payment plugin fails with the following error: ``` Column not found: 1054 Unknown column 'method_code' in 'where clause', query was: SELECT `paypal_billing_agreement`.* FROM `paypal_billing_agreement` WHERE (method_code = 'adyen_oneclick') AND (status = 'active') ``` **Cause** The Adyen Payment module re-creates the table during migration by adding the agreement_data field (via db_schema.xml). However, when attempting to migrate the billing agreements to the vault, the process fails to query the table using the `method_code` and `status` because these fields do not exist in the table. **Solution** Ensure VaultMigration does not fail if the `paypal_billing_agreement` table is missing or required fields are missing.
|
Hello @fahu, Thank you for your contribution and providing a fix for token migration issue. We will review and merge this PR if there is no issue. Best Regards, |
…with-disabled-paypal-module
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
previously approved these changes
Feb 25, 2025
…with-disabled-paypal-module
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
had a problem deploying
to
external
GitHub Actions
Failure
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
…ining table prefix" This reverts commit e59cbbc.
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
candemiralp
requested a deployment
to
external
GitHub Actions
Waiting
|
Hello @fahu, Once again, thank you for your contribution. We have completed the review and the logic seems pretty straight forwards. It makes a lot sense. However, we are having difficulty to pass the tests as the following exception is thrown after An example run summary can be found here. Do you have any idea about this issue? Best Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The installation/upgrade of the Adyen Payment plugin fails with the following error:
Cause
The Adyen Payment module re-creates the table during migration by adding the agreement_data field (via db_schema.xml). However, when attempting to migrate the billing agreements to the vault, the process fails to query the table using the
method_codeandstatusbecause these fields do not exist in the table.Solution
Ensure VaultMigration does not fail if the
paypal_billing_agreementtable is missing or required fields are missing.