Fix: Giftcard component unresponsive when requiring confirmation #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
requested review from
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 44402e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +84 B (+0.01%) Total Size: 770 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
|
ribeiroguilherme
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The giftcard component would get unresponsive if a second gift card would be used to make a finalise a payment. The UI would try to trigger
onRequiringConfirmationand crash. This callback is not necessary, and should be needed if the ourpayButtonis shown.Tested scenarios
Fixed issue: