Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowed python versions #21

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Update allowed python versions #21

merged 1 commit into from
Jul 23, 2023

Conversation

Cikmo
Copy link
Contributor

@Cikmo Cikmo commented Jul 18, 2023

This pull request expands the support to all versions below 4.0, including the existing support for 3.10. It allows for a wider dependency range of >=3.7.2,<4.0, effectively resolving the problem faced with strict dependency managers such as poetry. Previously, if the allowed Python version range exceeded the one specified in the library, it would not be permitted. However, with this change, poetry will be able to add the dependency even if you're using 3.12 or a higher version (which should be a non-issue).

Considering 3.11 is already supported, there is no
reason to not allow all <4.0 versions. This change
is essentially the same as writing >=3.7.2,<4.0.
@Aedial
Copy link
Owner

Aedial commented Jul 18, 2023

I knowingly avoided <4.0, as to ensure the specific version was fully functional before allowing it, like a lot of other packages using pyproject do.
I guess I could use the dependencies as a lock, but python version for the CI won't be automatically bumped, resulting in untested changes being pushed to Pypi.

@Cikmo
Copy link
Contributor Author

Cikmo commented Jul 19, 2023

I knowingly avoided <4.0, as to ensure the specific version was fully functional before allowing it, like a lot of other packages using pyproject do.

I guess I could use the dependencies as a lock, but python version for the CI won't be automatically bumped, resulting in untested changes being pushed to Pypi.

Thing is, I don't think I've seen any library that doesn't allow me to install because I'm using a greater version. All 3.x versions should be non-breaking for nearly all situations, unless you're doing something weird and very specific, which I doubt.

@Aedial Aedial merged commit a9ce62f into Aedial:main Jul 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants