Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #140

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Dev #140

merged 2 commits into from
Sep 16, 2024

Conversation

5hojib
Copy link
Collaborator

@5hojib 5hojib commented Sep 16, 2024

Summary by Sourcery

Enhance code readability by refining string formatting and async file operations, and update the deployment workflow to support optional Heroku Team Name input.

Enhancements:

  • Improve code readability by adjusting string formatting and removing unnecessary mode arguments in async file operations.

CI:

  • Update the deployment workflow to include an optional Heroku Team Name input, allowing for more flexible deployment configurations.

5hojib and others added 2 commits September 16, 2024 11:21
Deployment:

- Add support for specifying a Heroku team name in the deployment workflow, allowing deployments to be associated with a specific Heroku team.

---------

Co-authored-by: Mehedi Hasan Shojib <[email protected]>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link
Contributor

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request makes minor code improvements and adds a new feature to the Heroku deployment workflow. The changes include code formatting, error handling improvements, and the addition of an optional Heroku team name parameter for deployment.

File-Level Changes

Change Details Files
Improved string formatting and code style
  • Changed single quotes to double quotes for string formatting
  • Improved code formatting for better readability
  • Removed unnecessary whitespace
bot/helper/mirror_leech_utils/status_utils/qbit_status.py
bot/helper/mirror_leech_utils/download_utils/direct_link_generator.py
Enhanced Heroku deployment workflow
  • Added optional 'HK_TEAM_NAME' input parameter
  • Implemented conditional formatting for team parameter in deployment step
.github/workflows/deploy.yml
Simplified file opening operations
  • Removed 'r' mode specification when opening files for reading
  • Simplified 'aiopen' function calls
bot/__main__.py
bot/helper/mirror_leech_utils/rclone_utils/list.py
bot/helper/mirror_leech_utils/rclone_utils/transfer.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @5hojib - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@5hojib 5hojib merged commit 6db1e96 into main Sep 16, 2024
1 check passed
@5hojib 5hojib deleted the dev branch September 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants