-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ALM sentence #71
Add ALM sentence #71
Conversation
Codecov ReportBase: 79.84% // Head: 80.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 79.84% 80.22% +0.37%
==========================================
Files 24 25 +1
Lines 933 976 +43
==========================================
+ Hits 745 783 +38
- Misses 188 193 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/sentences/utils.rs
Outdated
use arrayvec::ArrayString; | ||
use chrono::{NaiveDate, NaiveTime}; | ||
use core::str; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was not needed.
Also it would be nice to keep core/std/alloc
separate from other imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, that's probably rustfmt
doing its thing 😅.
Regarding the use of core/std/alloc
, I'll move the number_in_range
parser to utils
to avoid spreading the import of core
Thank once again for this PR! |
No description provided.