Fix: take last task from the pending tasks#233
Open
crismacv wants to merge 1 commit intoAffineFoundation:mainfrom
Open
Fix: take last task from the pending tasks#233crismacv wants to merge 1 commit intoAffineFoundation:mainfrom
crismacv wants to merge 1 commit intoAffineFoundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a scheduling issue that causes executors to spend time running tasks that are no longer needed, which reduces overall evaluation throughput.
Problem
Tasks are rotated from the front of the queue at every
rotating_interval.Executors also fetch tasks from the front.
When an executor cannot finish
rotating_counttasks within one interval, tasks may be rotated before they are executed.As a result, executors can spend time running tasks that are already outdated, which leads to unnecessarily low evaluation speed.
Solution
Executors now fetch tasks from the end of the queue instead of the front.
Rotation continues to operate on the front of the queue.
This prevents in-progress tasks from being removed and improves evaluation throughput.