[BDX-67] Add constant to S3Client #27
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaklaassen-affirm do you know if the version needs to be bumped in setup.py, or the change needs to be merged to a new branch? |
jaklaassen-affirm
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
luigi==2.7.5+affirm.1.4.8, S3Client was previously upgraded to boto3: PR here. 2 AffirmS3Clients in the all-the-things repo -- toolbox2/luigi and toolbox.affirmluigi2 -- will also need to be updated alongside any luigi package upgrade. auses_boto3constant is added to the S3Client version upgrade so that any changes to AffirmS3Clients will be limited only to DTs upgrading luigi.