feat(indexer): add GET /collections/:address/stats endpoint and tests… - #600
Open
Sensei-Victor wants to merge 2 commits into
Open
feat(indexer): add GET /collections/:address/stats endpoint and tests…#600Sensei-Victor wants to merge 2 commits into
Sensei-Victor wants to merge 2 commits into
Conversation
…Afristore#577) - Add route that aggregates totalVolume (sum of Sold listings), floorPrice (min price of Active listings), and totalItems (count) for a collection - Route validates the collection exists first, returns 404 if not found - Route placed before /collections/:address to prevent param shadowing - Add collection.findUnique mock to the test mock setup - Add 4 test cases: happy path aggregation, null floor/volume, 404, 500
|
@Sensei-Victor is attempting to deploy a commit to the ultratechcode's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Sensei-Victor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Sensei-Victor, Some of the CI checks are failing. Kindly investigate and fix the issue. Thank you your contribution |
Author
|
Could someone please approve the pending workflow so the checks can run? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #565
… (#577)
Description
Resolves Issue: ### Soroban Safety Checklist
Persistentstorage, I explicitly calledextend_ttlfor those exact keys immediately after setting them.extend_instance_ttlis called if this is a public, state-modifying entry point.require_authis used correctly and doesn't accidentally block approved operators or token owners..get(i).unwrap()host calls inside loops.Vecarrays for global state tracking.deploy_v2, I hashed the caller's address into the deployment salt..unwrap_or()combined with.saturating_sub()to silently hide balance underflows.Testing
cargo test).Closes #577
Additional Context