Implement update_royalty_split Function with Admin Authorization - #629
Open
syed-ghufran-hassan wants to merge 1 commit into
Open
Implement update_royalty_split Function with Admin Authorization#629syed-ghufran-hassan wants to merge 1 commit into
syed-ghufran-hassan wants to merge 1 commit into
Conversation
|
@syed-ghufran-hassan is attempting to deploy a commit to the ultratechcode's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the missing update_royalty_split function that was referenced in GitHub Issues #80 and #81. Previously, admins had no way to update royalty splits once the contract was deployed. This PR adds the functionality with proper admin authentication and input validation.
Closes Issue: # #626
🛠️ Stack Checklists
Please fill out the checklist(s) relevant to your changes. You can delete the sections that do not apply.
🖥️ Frontend (Next.js / React)
⚙️ Backend Indexer (Node.js / Prisma)
revertLedgersproperly rolls back the state on ledger reorgs.⛓️ Smart Contracts (Soroban / Rust)
Persistentstorage, I explicitly calledextend_ttlimmediately after setting.extend_instance_ttlis called if this is a public, state-modifying entry point.require_auth()is used correctly and doesn't block approved operators..get(i).unwrap()host calls inside loops.Vecarrays for global state tracking.🧪 Testing & CI
cargo test,npm run test, ornpx playwright test).📸 Screenshots / Screen Recording
If your PR introduces visual changes, please attach screenshots.
Additional Context
Any other context or special instructions for reviewers.