fix(combat): fix npe for post-combat items

After-the-End-of-All-Things · Sep 26, 2023 · bde561d · bde561d
1 parent a3f1735
commit bde561d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/client/src/app/pages/explore/explore.page.html b/client/src/app/pages/explore/explore.page.html
@@ -205,7 +205,7 @@
                               <div class="formation-count">
                                 {{
                                 actionInfo.actionData.formation.monsters.length
-                                }} monsters
+                                }} monster(s)
                               </div>
                             </ion-col>
                           </ion-row>

diff --git a/server/src/modules/fight/fight.service.ts b/server/src/modules/fight/fight.service.ts
@@ -4,6 +4,7 @@ import {
   ICombatTargetParams,
   IFightCharacter,
   IFightTile,
+  IItem,
   IMonster,
   IMonsterFormation,
   TrackedStat,
@@ -349,14 +350,16 @@ export class FightService {
         .filter(Boolean),
     );
 
-    let randomDrop;
+    let randomDrop: IItem | undefined;
 
     if (
       randomDropPossibility &&
       random(0, 100) <= randomDropPossibility.chance
     ) {
       randomDrop = this.contentService.getItem(randomDropPossibility.item);
-      addStatusMessage(fight, 'Fight', `You found "${randomDrop.name}"!`);
+      if (randomDrop) {
+        addStatusMessage(fight, 'Fight', `You found "${randomDrop.name}"!`);
+      }
     }
 
     if (isWin && fight.defenders.length > 0) {
@@ -368,7 +371,7 @@ export class FightService {
       `Fight ${
         fight.internalId
       } rewarded ${xpDelta} XP and ${coinDelta} coins and ${
-        randomDrop?.item ?? 'no'
+        randomDrop?.name ?? 'no'
       } item drop.`,
     );