Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title changing to router #72

Merged
merged 2 commits into from
Jun 24, 2023
Merged

add title changing to router #72

merged 2 commits into from
Jun 24, 2023

Conversation

sarimash
Copy link
Contributor

@sarimash sarimash commented Jun 24, 2023

Description

Names can be changed if desired; I used 'My Profile' for the profile to distinguish from other players' but did not use My on 'Inventory' or 'Collections' because the player would not be viewing other players'.
image
image

If the data field is populated, we use the data field + " | AtEoAT" otherwise we default to the game's name, as in the home page:
image

Also noticed that the original default on the index page was using the wrong name for the game, so threw in a quick fix for that.

Fixes #18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (npm run test) that prove my fix is effective or that my feature works

@seiyria seiyria merged commit c056bda into main Jun 24, 2023
2 checks passed
@seiyria seiyria deleted the issue-18 branch June 24, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add title changing to router
2 participants