Fix #449: implement TagFx, AvatarFx, and TooltipFx components#451
Merged
roblevintennis merged 7 commits intomasterfrom Mar 21, 2026
Merged
Conversation
Add three new Fx animation components following the BadgeFx/ButtonFx pattern: - TagFx (ag-tag-fx): extends AgTag, targets .tag-wrapper - AvatarFx (ag-avatar-fx): extends Avatar, targets .avatar - TooltipFx (ag-tooltip-fx): extends Tooltip, targets .tooltip Each component includes core (_Fx.ts + Fx.ts), React wrapper, Vue wrapper, vue/index.ts, and spec file (93 tests total, all passing). Also adds 9 package.json exports, updates FX_COMPONENTS in stories.ts, and marks all Fx components done in FX_PLAN.md.
…ries Add docs pages, example files (Vue/Lit/React), and sidebar navigation for the three new Fx components introduced in issue #449. Requires rebuilding and reinstalling agnosticui-core locally before the live previews will work (npm run build && npm pack in v2/lib, then npm run reinstall:lib in v2/site).
…Fx override Required for TagFx, AvatarFx, TooltipFx static styles override to typecheck. Also fix TooltipFx firstUpdated/updated signatures to match Tooltip base class.
✅ Deploy Preview for agnosticui-demo-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5 tasks
✅ Deploy Preview for agnosticui-demo-vue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agnosticui-demo-lit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ui/dom type resolution ts-morph uses v2/lib/tsconfig.json and needs @floating-ui/dom in v2/lib/node_modules to resolve the Placement union type. Without it, inherited placement props in TooltipFxProps are dropped silently, causing check-codegen drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TagFx(ag-tag-fx),AvatarFx(ag-avatar-fx), andTooltipFx(ag-tooltip-fx) components following the existingBadgeFx/ButtonFx/IconButtonFxpattern_ComponentFx.ts+ComponentFx.ts(Lit),ReactComponentFx.tsx,VueComponentFx.vue,vue/index.ts, and a spec file (93 tests, all passing)package.jsonexports (./tag-fx,./tag-fx/react,./tag-fx/vue, etc.)FX_COMPONENTSset in CLIstories.tsagnosticui-coreto2.0.0-alpha.25and reinstalls in sitestatic styles: CSSResultGroupannotation onAgTag,Avatar, andTooltipcanonical classes (required for Fx override to typecheck)v2/docs/FX_PLAN.mdTest plan
npm run lint && npm run typecheck && npm run test && npm run build && npm packinv2/libpasses cleannpm run docs:devinv2/siteshows AvatarFx (Lab), TagFx (Lab), TooltipFx (Lab) in sidebar