Issue 460/sdui skipped components#471
Merged
roblevintennis merged 7 commits intomasterfrom Mar 27, 2026
Merged
Conversation
Removes Collapsible from skipComponents and adds it as a rendererPrimitive.
The named summary slot requires a manual renderer case; the new reactImport,
vueImport, and litImport fields on RendererPrimitive inject the necessary
import lines into each renderer without auto-generation conflicts.
Schema: AgCollapsibleNode gains summary, open, bordered, shadow, useChevron,
useX, useMinus, noIndicator, and on_toggle. The on_toggle action dispatches
{ id, value: boolean } so consumers can track open/closed state.
Also adds:
- collapsible-demo.ts fixture demonstrating accordion behavior
- CollapsibleDemo component for React, Vue, and Lit demos
- Picker card so the collapsible demo is selectable in all three apps
- Group 4 permanent skip comments in skipComponents for ScrollProgress,
ScrollToButton, SidebarNav, and VisuallyHidden
…for Regenerate CollapsibleDemo lacked CSS to space the three ag-collapsible panels apart (gap now applied via flex on ag-dynamic-renderer) and the Regenerate button had no effect because seed was never passed down. Added seed property with updated() lifecycle to restart the stream on regenerate, matching the StreamingOutput pattern.
…o stateful demo
Removes Slider and Pagination from skipComponents. Adds on_change payload
wiring for both in all three renderers (React, Vue, Lit). onPageChange maps
to on_change emitting { id, value: page }.
Extends the collapsible fixture into a broader "Stateful components" demo:
the three accordion panels are followed by a 0-10 Slider whose on_change
updates a live Count label via SLIDER_CHANGE action. Picker card renamed
accordingly. Pagination is codegen-only with no demo fixture (requires
paginated data context to be meaningful).
check-codegen passes; all 7 generated files in sync.
All five ag-selection-card elements in the workflow picker now share a consistent 240px minimum height (height of the tallest 'Stateful components' card). Applied via ag-selection-card::part(ag-selection-card-container) with box-sizing: border-box. Lit requires the rule in WorkflowPicker.ts (shadow DOM scope); React and Vue use their global stylesheets.
Matches the Node array panel behaviour present in StreamingOutput and AdaptiveOutput: opens automatically when the stream starts, auto-closes after 8s, and can be toggled manually. Panel open state resets on Regenerate (seed change). Includes the node-panel CSS in each framework's appropriate scope (shadow styles for Lit, shared StreamingOutput.css import for React, non-scoped style block for Vue).
✅ Deploy Preview for agnosticui-demo-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agnosticui-demo-lit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agnosticui-demo-vue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#460