Fix #469: wrap --ag-focus in rgba() to restore invisible focus rings#472
Merged
roblevintennis merged 3 commits intomasterfrom Mar 27, 2026
Merged
Fix #469: wrap --ag-focus in rgba() to restore invisible focus rings#472roblevintennis merged 3 commits intomasterfrom
roblevintennis merged 3 commits intomasterfrom
Conversation
--ag-focus is a raw RGB triplet, not a hex color, so it must be used as rgba(var(--ag-focus), 0.5) to produce a valid outline color. Matches the pattern already used by ag-accordion-item.
…Button Audit of v2/lib components revealed four more components using bare var(--ag-focus) as an outline color. Since --ag-focus is a raw RGB triplet, it must be wrapped in rgba() to produce a valid CSS color. Aligns all components with the correct pattern already used by Accordion, Button, Checkbox, Input, Link, Pagination, Radio, Toggle, and others.
✅ Deploy Preview for agnosticui-demo-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agnosticui-demo-lit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agnosticui-demo-vue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ag-focusis a raw RGB triplet token (e.g.210, 105, 30), so using it bare assolid var(--ag-focus)produces an invalid CSS color and an invisible focus ringrgba(var(--ag-focus), 0.5), matching the correct pattern already used by Accordion, Button, Checkbox, Input, Link, etc.Components fixed:
Collapsible—summary:focus-visible(primary issue)Badge— interactive badge:focus-visibleBreadcrumb— link:focus-visibleMenu— button/a:focusIconButton— button:focus-visibleTest plan
ag-collapsibleinv2/sdui/demo-litvia keyboard Tab navigationstatic styles, so React and Vue wrappers inherit it automaticallyCloses #469