Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 59 USDC PSM #192

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat: 59 USDC PSM #192

merged 5 commits into from
Nov 20, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Nov 4, 2024

closes #19

adopt a passed proposal checklist is for proposals migrated from agoric-sdk. This one is not.

@dckc
Copy link
Member Author

dckc commented Nov 4, 2024

I'm not sure what to make of this ci error:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@agoric/synthetic-chain' imported from /usr/src/proposals/59:usdc-psm/eval_submission.js

@turadg ? clues?

@dckc dckc requested a review from turadg November 4, 2024 18:49
@turadg
Copy link
Member

turadg commented Nov 6, 2024

I'm not sure what to make of this ci error:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@agoric/synthetic-chain' imported from /usr/src/proposals/59:usdc-psm/eval_submission.js

Seems like a bug in the default CoreEvalProposal handler. Try making an eval.sh like https://github.com/Agoric/agoric-3-proposals/blob/d55bfe013865ad3d4d790756d40ec52ecd0370a0/proposals/76%3Avaults-auctions/eval.sh

@dckc
Copy link
Member Author

dckc commented Nov 18, 2024

... Try making an eval.sh like ...

tried it in 9b80e3c
no joy. symptoms persist

Is something supposed to run yarn install but didn't?

@dckc
Copy link
Member Author

dckc commented Nov 19, 2024

Why is test-package failing? I didn't touch the package.

Error: src/lib/vstorage.js(23,19): error TS2307: Cannot find module '@agoric/cosmic-proto/dist/codegen/agoric/vstorage/query.js' or its corresponding type declarations.

https://github.com/Agoric/agoric-3-proposals/actions/runs/11919580128/job/33219589451?pr=192#step:7:9

@dckc
Copy link
Member Author

dckc commented Nov 19, 2024

no test.sh????

[59:usdc-psm] Running test.sh.
./run_test.sh: line 34: ./test.sh: No such file or directory

https://github.com/Agoric/agoric-3-proposals/actions/runs/11918437804/job/33215866300?pr=192#step:11:5085

It's right there!!!
https://github.com/Agoric/agoric-3-proposals/blob/dc-59-usdc/proposals/59%3Ausdc-psm/test.sh

@dckc dckc enabled auto-merge (rebase) November 19, 2024 23:39
@dckc
Copy link
Member Author

dckc commented Nov 20, 2024

I see you got it all green, @turadg . Go ahead and approve?

@dckc dckc merged commit fdcf661 into main Nov 20, 2024
2 checks passed
@dckc dckc deleted the dc-59-usdc branch November 20, 2024 14:40
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request Nov 21, 2024
closes: #10492

## Description

Adds `f:fast-usdc` that invokes `init-fast-usdc.js` and such.

### Security / Scaling / Upgrade Considerations

Nothing novel to this PR.

### Documentation Considerations

DRAFT until:
 - [x] Update a3p-integration documentation with how to get a chain running at a particular post-proposal configuration.

### Testing Considerations

tests that `agoricNames.instance.fastUsdc` is present.

includes a work-around for...
 - Agoric/agoric-3-proposals#192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSM proposal 59 (USDC)
2 participants