Repair Kread since we're upgrading Zoe #10327
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
Zoe
dckc
reviewed
Oct 23, 2024
golang/cosmos/app/upgrade.go
Outdated
Comment on lines
95
to
98
| vm.CoreProposalStepForModules( | ||
| // Upgrade Zoe (no new ZCF needed). | ||
| "@agoric/builders/scripts/vats/upgrade-zoe.js", | ||
| ), |
There was a problem hiding this comment.
I'm confused by the scope of this PR. Isn't upgrade-zoe.js already in the target branch?
There was a problem hiding this comment.
github is confused. It's showing what's supposed to be the base commit, rather than the new one. 784104 is the new commit. Let me rattle something and see what shakes out.
There was a problem hiding this comment.
That didn't work. I'll whack it again after #10279 merges.
There was a problem hiding this comment.
rebased. It looks right now.
Chris-Hibbert
force-pushed
the
10267-kreadToo
branch
from
7841043
to
aa7f0a9
Compare
Deploying agoric-sdk with
|
| Latest commit: |
450698a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d7b869f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10267-kreadtoo.agoric-sdk.pages.dev |
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
Chris-Hibbert
force-pushed
the
10267-ZoeUpgrade
branch
from
4672167
to
e846f5e
Compare
Chris-Hibbert
force-pushed
the
10267-kreadToo
branch
from
aa7f0a9
to
450698a
Compare
dckc
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10267
Description
We'll be upgrading Zoe in the next SW upgrade. We need to reset the KREAd subscribers when we do that.
Security Considerations
No broader security implications
Scaling Considerations
Not a scaling concern
Documentation Considerations
I should have remembered this when adding the Zoe upgrade.
Testing Considerations
None
Upgrade Considerations
There's a constraint that we need to enforce when we upgrade Zoe. So far, we've been remembering it, but it would be better to automate.