'make' namespace for kinds #10666
'make' namespace for kinds #10666
Conversation
|
|
||
| const { make } = organizeMakers({ | ||
| ...orchestrateAll(flows, {}), | ||
| makeSettler: prepareSettler(zone, { |
There was a problem hiding this comment.
I thought about a record like this, but sometimes you have to pass makeA into prepareB.
There was a problem hiding this comment.
oh good point. That thought crossed my mind while I was refactoring but it consolidating like this was too delicious
Deploying agoric-sdk with
|
| Latest commit: |
c1e4cea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63de8717.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-make-namespace.agoric-sdk.pages.dev |
| if (!key.startsWith('make')) { | ||
| throw new Error(`Unexpected key ${key}`); | ||
| } | ||
| const newKey = key.slice(4); // Remove 'make' |
There was a problem hiding this comment.
| const newKey = key.slice(4); // Remove 'make' | |
| const newKey = key.slice('make'.length); |
| make[newKey] = fn; | ||
| } | ||
| // @ts-expect-error cast | ||
| return harden({ make }); |
There was a problem hiding this comment.
why a record? why not return make;? in case there are other facets later or something? that doesn't seem like your style.
There was a problem hiding this comment.
To enforce that the name used is make. Though that could be done by a lint rule, like React's useState does to enforce that the tuple it returns of [state object, state setter] has the the consistent naming [myState, setMyState].
variant of #10663
Description
Defines a convention (with a helper) for a
makeobject that has kind constructors.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations