chore: correct declaration of userSeat.getPayout(); cascade fixes #10738
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
8610-getPayout-type
branch
from
2666d59 to
a8c4ad5
Compare
Deploying agoric-sdk with
|
| Latest commit: |
a8c4ad5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cae7ae5.agoric-sdk.pages.dev |
| Branch Preview URL: | https://8610-getpayout-type.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8610
Description
Improve declaration for
E(userSeat).getPayout()'s return value. A few assertions were added where the type needed to be narrowed. If the types weren't correct, the called code would have thrown anyway.Security Considerations
No impact
Scaling Considerations
Not relevant
Documentation Considerations
Mostly documentation. The generated docs will be updated automatically. I'll create a separate PR to update the manual docs.
Testing Considerations
Tests unaffected.
Upgrade Considerations
No relevance/