chore: chain policies for all chains#10829
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 9, 2025
Merged
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
34228ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4dcdc062.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-mn-chain-policies.agoric-sdk.pages.dev |
samsiegart
approved these changes
Jan 9, 2025
| attenuatedCttpBridgeAddress: '0xTODO', | ||
| cctpTokenMessengerAddress: '0x9f3B8679c73C2Fef8b59B4f3444d4e156fb70AA5', | ||
| chainId: 80002, | ||
| confirmations: 2, // TODO mocked |
Contributor
There was a problem hiding this comment.
Mocked as in we expect this number to change? It doesn't feel like an actual mock, maybe a placeholder value.
Contributor
Author
There was a problem hiding this comment.
Yes placeholder is better, will update
| }, | ||
| // Polygon PoS Amoy | ||
| Polygon: { | ||
| attenuatedCttpBridgeAddress: '0xTODO', |
Contributor
There was a problem hiding this comment.
Do these not have bridge addresses, or just unknown? Do we even care since it's just testnet?
Contributor
Author
There was a problem hiding this comment.
Uknown and harder to find than the mainnet ones. Reached out for a list and will update when we receive them
0xpatrickdev
force-pushed
the
pc/mn-chain-policies
branch
from
9793054 to
34228ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #10714
Description
attenuatedCttpBridgeAddressandcctpTokenMessengerAddress.cctpTokenMessengerAddressandchainId(* Sepolia network for most, as that's where Circle deploys)Security Considerations
None really, but it's important these are the correct values.
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
None
Upgrade Considerations
None, part of initial release.