refactor: anylogger reform #11930
Draft
refactor: anylogger reform #11930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c129467
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37df852a.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-anylogger-reform.agoric-sdk.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors anylogger configuration in two packages to improve consistency and code quality. The changes standardize variable naming, add proper type annotations, and enhance function definitions with explicit naming.
Key changes:
- Standardized variable naming (
selectedLevel→maxActiveLevel,l→logger) - Added JSDoc type imports and annotations for better type safety
- Enhanced function definitions with
defineNamefor better debugging
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cosmic-swingset/src/anylogger-agoric.js | Reordered imports, improved JSDoc formatting, and hardened VAT_LOGGER_PREFIXES array |
| packages/agoric-cli/src/anylogger-agoric.js | Major refactor with consistent variable naming, type annotations, and enhanced function definitions |
| * As documented in ../../../docs/env.md, the log level defaults to "log" when | ||
| * environment variable DEBUG is non-empty or unset, and to the quieter "info" | ||
| * when it is set to an empty string, but in either case is overridden if DEBUG | ||
| * environment variable DEBUG is non-empty or `'unset'`, |
There was a problem hiding this comment.
Inconsistent use of backticks around 'unset'. The original code used double quotes, and this should maintain consistency with the surrounding text formatting.
Suggested change
| * environment variable DEBUG is non-empty or `'unset'`, | |
| * environment variable DEBUG is non-empty or "unset", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations