Skip to content

refactor: stop using deprecated "sloppy" interface option #11931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor: stop using deprecated "sloppy" interface option #11931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/inter-protocol/src/price/fluxAggregatorKit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ export const prepareFluxAggregatorKit = async (
baggage,
'fluxAggregator',
{
creator: M.interface('fluxAggregator creatorFacet', {}, { sloppy: true }),
creator: M.interface(
'fluxAggregator creatorFacet',
{},
{ defaultGuards: 'passable' },
),
public: M.interface('fluxAggregator publicFacet', {
getPriceAuthority: M.call().returns(M.any()),
getPublicTopics: M.call().returns({
Expand Down
4 changes: 2 additions & 2 deletions packages/inter-protocol/src/vaultFactory/vaultManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,9 @@ export const prepareVaultManagerKit = (
}),
helper: M.interface(
'helper',
// not exposed so sloppy okay
// not exposed so using `defaultGuards` is fine.
{},
{ sloppy: true },
{ defaultGuards: 'passable' },
),
manager: M.interface('manager', {
getGovernedParams: M.call().returns(M.remotable('governedParams')),
Expand Down
4 changes: 2 additions & 2 deletions packages/internal/src/typeGuards.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export const StorageNodeShape = M.remotable('StorageNode');
export const UnguardedHelperI = M.interface(
'helper',
{},
// not exposed so sloppy okay
{ sloppy: true },
// not exposed so using `defaultGuards` is fine.
{ defaultGuards: 'passable' },
);

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/zoe/src/contractFacet/zcfSeat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const createSeatManager = (
return activeZCFSeats.get(zcfSeat);
};

const ZCFSeatI = M.interface('ZCFSeat', {}, { sloppy: true });
const ZCFSeatI = M.interface('ZCFSeat', {}, { defaultGuards: 'passable' });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strikes me as a particular dangerous place to omit explicit method guards. Am I missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is not relevant to this PR though. Just asking.


const makeZCFSeatInternal = prepareExoClass(
zcfBaggage,
Expand Down
Loading