Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadgen to deployment integration test #4256

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 8, 2022

refs: #3444

Description

This change leverages the loadgen work, and stacks it on top of #4133 to run a short loadgen cycle against the 2 node testnet started by the integration test.

Unlike #3107, the goal is not to generate perf data (even though some very basic deploy times might be useful), but to make sure changes to agoric-sdk do not break the loadgen which is a simple representative of dapps.

It should also help catch some non-determinism source (see #3444), but only if caused by different SwingSet executions. It would probably not catch restart related non-determinism.

Security Considerations

This should not have any impact on security, and is modeled against the dapp integration test which also checks out another Agoric owned repository.

Testing Considerations

In general SDK breaking changes should be accommodated in the loadgen in a backwards compatible manner, so that the loadgen can run against both old and new versions of the SDK. That usually means merging a loadgen fix first, then running the integration test in the SDK's PR. If necessary, an SDK PR can target a specific loadgen branch using the following PR notation: #loadgen-branch: main (replace main with the branch name).

@mhofman mhofman requested a review from michaelfig January 8, 2022 04:11
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach and current details look great!

If minor tweaks to pass CI are all you need, you can consider this to be my approval. Rerequest a review only if you make other changes.

packages/deployment/src/init.js Show resolved Hide resolved
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from bc86673 to ec74139 Compare January 8, 2022 05:02
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from ec74139 to 8f0045d Compare January 8, 2022 08:36
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch 4 times, most recently from bb9be38 to f8c7327 Compare February 6, 2022 04:15
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from f8c7327 to d75d008 Compare February 6, 2022 15:22
@mhofman mhofman changed the base branch from master to mfig-3742-flight-recorder February 7, 2022 00:29
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from d75d008 to c9ce136 Compare February 7, 2022 00:29
@michaelfig michaelfig force-pushed the mfig-3742-flight-recorder branch from 1fdc4a1 to a1295ec Compare February 7, 2022 01:52
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from c9ce136 to 0155ada Compare February 7, 2022 02:05
@michaelfig michaelfig force-pushed the mfig-3742-flight-recorder branch from a1295ec to a8a4232 Compare February 7, 2022 03:01
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch 2 times, most recently from 2c6f75d to 13ad2ae Compare February 7, 2022 21:21
@michaelfig michaelfig force-pushed the mfig-3742-flight-recorder branch 2 times, most recently from d3fb18a to bfe877e Compare February 7, 2022 22:14
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from 13ad2ae to 7c29a59 Compare February 7, 2022 22:29
@michaelfig michaelfig force-pushed the mfig-3742-flight-recorder branch 2 times, most recently from b1440e0 to b7123f6 Compare February 7, 2022 22:54
Base automatically changed from mfig-3742-flight-recorder to master February 8, 2022 08:33
@mhofman mhofman force-pushed the mhofman/loadgen-integration branch 3 times, most recently from 9bb5070 to 20de397 Compare February 9, 2022 02:16
@mhofman
Copy link
Member Author

mhofman commented Feb 9, 2022

@michaelfig I have not materially changed the PR since the review, so I will merge in a few unless I get any objections (after removing the PR trigger)

@mhofman mhofman force-pushed the mhofman/loadgen-integration branch from 20de397 to c1f3c19 Compare February 9, 2022 19:13
@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label Feb 9, 2022
@mergify mergify bot merged commit 9d7286e into master Feb 9, 2022
@mergify mergify bot deleted the mhofman/loadgen-integration branch February 9, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants