-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadgen to deployment integration test #4256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach and current details look great!
If minor tweaks to pass CI are all you need, you can consider this to be my approval. Rerequest a review only if you make other changes.
bc86673
to
ec74139
Compare
ec74139
to
8f0045d
Compare
bb9be38
to
f8c7327
Compare
f8c7327
to
d75d008
Compare
d75d008
to
c9ce136
Compare
1fdc4a1
to
a1295ec
Compare
c9ce136
to
0155ada
Compare
a1295ec
to
a8a4232
Compare
2c6f75d
to
13ad2ae
Compare
d3fb18a
to
bfe877e
Compare
13ad2ae
to
7c29a59
Compare
b1440e0
to
b7123f6
Compare
9bb5070
to
20de397
Compare
@michaelfig I have not materially changed the PR since the review, so I will merge in a few unless I get any objections (after removing the PR trigger) |
Avoid overloading the CI env so it can actually complete some tasks
20de397
to
c1f3c19
Compare
refs: #3444
Description
This change leverages the loadgen work, and stacks it on top of #4133 to run a short loadgen cycle against the 2 node testnet started by the integration test.
Unlike #3107, the goal is not to generate perf data (even though some very basic deploy times might be useful), but to make sure changes to
agoric-sdk
do not break the loadgen which is a simple representative of dapps.It should also help catch some non-determinism source (see #3444), but only if caused by different SwingSet executions. It would probably not catch restart related non-determinism.
Security Considerations
This should not have any impact on security, and is modeled against the dapp integration test which also checks out another Agoric owned repository.
Testing Considerations
In general SDK breaking changes should be accommodated in the loadgen in a backwards compatible manner, so that the loadgen can run against both old and new versions of the SDK. That usually means merging a loadgen fix first, then running the integration test in the SDK's PR. If necessary, an SDK PR can target a specific loadgen branch using the following PR notation:
#loadgen-branch: main
(replacemain
with the branch name).