chore: Integrate on top of upgrade-15

[gibson042]

Fixes #9260

Description

As of Agoric/agoric-3-proposals#157 , a3p:latest now includes results of upgrade-15. This removes the duplication from the UNRELEASED upgrade handler and a3p-integration.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

How much of the upgrade-15 a3p-integration should remain in a:upgrade-next? I'm thinking specifically about exit-reclaim.test.js and associated preparation.

Upgrade Considerations

@Chris-Hibbert Does initial.test.js needs some extension for the vaultFactory and/or scaledPriceAuthority upgrades?

[turadg]

How much of the upgrade-15 a3p-integration should remain in a:upgrade-next?

Everything that's not already tested in the A3P repo.

I'm thinking specifically about exit-reclaim.test.js and associated preparation.

That is covered in https://github.com/Agoric/agoric-3-proposals/tree/main/proposals/74%3Aupgrade-15

So please remove all tests in upgrade-next that aren't testing upgrade-next changes.

[Chris-Hibbert]

for Upgrade 16, we want to replace upgrade ZCF only with upgrade Zoe. I presume that's separate from this.

[mhofman]

Since the failing test indicates that a ZCF upgrade is needed, this PR should at least maintain the ZCF upgrade core proposal. Since the plan for the next upgrade seem to upgrade both Zoe and ZCF, we could also do that instead in this PR.

[Chris-Hibbert]

Does initial.test.js need some extension for the vaultFactory and/or scaledPriceAuthority upgrades?

I don't think it'll be necessary to add anything.

[gibson042]

I'm seeing failures in c:stake-bld/stakeBld.test.js broadcasting executeOffer with offer id 'request-stake': https://github.com/Agoric/agoric-sdk/actions/runs/9321875452/job/25661786100?pr=9436#step:9:2071

SwingSet: ls: v77: TypeError: atomicTransfer: no function
at atomicTransfer (.../zoe/src/contractSupport/atomicTransfer.js:97)
at withdrawFromSeat (.../zoe/src/contractSupport/zoeHelpers.js:228)
at withdrawFromSeat (.../zoe/src/contractSupport/zoeHelpers.js:225)
at (.../orchestration/src/examples/stakeBld.contract.js:88)
at ()
at ()

Is that meaningful to anyone here?

[Chris-Hibbert]

#8520 points to this problem.
#7900 changed the helper to rely on the new ZCF. #7900 shouldn't be used to build bundles before upgrade 16 is on chain.

I guess bundles in A3P are built from HEAD, which can be incompatible

[Chris-Hibbert]

What are the chances that the proposal for orchestration ran before the proposal that set a new ZCF version? If that happened, stakeBid could have been built against a support library that presumed that ZCF was updated, but then deployed against the ZCF that hadn't yet changed.

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	147ee96
Status:	✅  Deploy successful!
Preview URL:	https://7350fbc8.agoric-sdk.pages.dev
Branch Preview URL:	https://gibson-9260-a3p-integration.agoric-sdk.pages.dev

View logs

[gibson042]

For posterity, the ZCF changes in upgrade-15 were intentionally minimal (and in particular excluded the addition of atomicRearrange), so upgrade-16 needs its own ZCF upgrade. Adding that to this PR fixed the above issue.