-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 notify signing error #11
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,11 @@ import { IST_ICON } from 'assets/assets'; | |
import type { BrandInfo } from 'store/app'; | ||
import { wellKnownBrands } from 'config'; | ||
|
||
export const notifyError = err => { | ||
console.log(err); | ||
window.alert(err); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not alert(err.message)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok. I was worried about |
||
}; | ||
|
||
const getLogoForBrandPetname = (brandPetname: string) => { | ||
switch (brandPetname) { | ||
case 'IST': | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth alerting here too? (Maybe if/when we get time we can add a toast instead of alert)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured if this part fails there's not anything they can do. for the signing error they can get more funds.