-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests if not enough balance #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
changed the base branch from
main
to
rs-decimal-places-verification
October 11, 2024 06:12
Deploying agoric-dapp-inter-emerynet with Cloudflare Pages
|
rabi-siddique
added
the
liquidation-reconstitution-testing
Trigger E2E tests for Liquidation-Reconstitution
label
Oct 11, 2024
rabi-siddique
force-pushed
the
rs-skip-tests-if-not-enough-balance
branch
2 times, most recently
from
October 11, 2024 09:33
1e378e8
to
e2ed085
Compare
frazarshad
approved these changes
Oct 11, 2024
rabi-siddique
force-pushed
the
rs-skip-tests-if-not-enough-balance
branch
from
October 11, 2024 10:44
e2ed085
to
76a4deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
liquidation-reconstitution-testing
Trigger E2E tests for Liquidation-Reconstitution
liquidation-testing
Trigger E2E tests for Liquidation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
user1
andbidder
balance before executing all tests. This is done to exit early in case the balances are not enough to carry out test operations. Previously, we had executed a major section of tests before realizing that we didn't possess enough balance to create a vault or make a bid.gov1
has enoughIST
to make bids. But this is no longer required becausegov1
already have enough balance to carry out bidding stuff.agops
andagd
.