-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update agoric synpress to latest #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
force-pushed
the
rs-update-agoric-synpress
branch
from
December 17, 2024 04:39
512a7cb
to
15d9264
Compare
Deploying dapp-inter-test with Cloudflare Pages
|
rabi-siddique
force-pushed
the
rs-update-agoric-synpress
branch
from
December 17, 2024 04:40
15d9264
to
15d51b9
Compare
Deploying agoric-dapp-inter-emerynet with Cloudflare Pages
|
frazarshad
approved these changes
Dec 17, 2024
Are we fixing this then? @rabi-siddique |
Yes. I will be inspecting this failure. |
Muneeb147
approved these changes
Dec 23, 2024
Merging. Will inspect the local failures with chrome and create a separate PR for fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@agoric/synpress
version3.8.3-beta.0
has been causing failures in both CI and local environments when running e2e tests with Chrome. Fortunately, our CI primarily utilizes the Chromium browser, which hasn’t been affected.Today, I encountered issues locally today while conducting liquidation tests to verify the indexing of liquidation data. To resolve this, I upgraded @agoric/synpress
to
3.8.3`, the latest version, which is compatible with Chrome and resolves these issues.