Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update agoric synpress to latest #391

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Dec 17, 2024

The @agoric/synpress version 3.8.3-beta.0 has been causing failures in both CI and local environments when running e2e tests with Chrome. Fortunately, our CI primarily utilizes the Chromium browser, which hasn’t been affected.

Today, I encountered issues locally today while conducting liquidation tests to verify the indexing of liquidation data. To resolve this, I upgraded @agoric/synpressto3.8.3`, the latest version, which is compatible with Chrome and resolves these issues.

@rabi-siddique rabi-siddique force-pushed the rs-update-agoric-synpress branch from 512a7cb to 15d9264 Compare December 17, 2024 04:39
Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2024

Deploying dapp-inter-test with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15d51b9
Status: ✅  Deploy successful!
Preview URL: https://5cb85de3.dapp-inter-test.pages.dev
Branch Preview URL: https://rs-update-agoric-synpress.dapp-inter-test.pages.dev

View logs

@rabi-siddique rabi-siddique force-pushed the rs-update-agoric-synpress branch from 15d9264 to 15d51b9 Compare December 17, 2024 04:40
Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2024

Deploying agoric-dapp-inter-emerynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15d51b9
Status: ✅  Deploy successful!
Preview URL: https://56b75cf8.agoric-dapp-inter-emerynet.pages.dev
Branch Preview URL: https://rs-update-agoric-synpress.agoric-dapp-inter-emerynet.pages.dev

View logs

Copy link

github-actions bot commented Dec 17, 2024

Network:
Commit: 621d214
Ref: refs/heads/main
IPFS v1 hash: bafybeiaruf2dkeor34r2dzkzmvuev53e6jb37vafprmq6g4sn2x7f3lmfy
CF - DWeb - 4EVERLAND

@rabi-siddique
Copy link
Contributor Author

Let's not merge this. The latest version of @agoric/synpress fails for transaction signing popups.
image

@Muneeb147
Copy link

Let's not merge this. The latest version of @agoric/synpress fails for transaction signing popups. image

Are we fixing this then? @rabi-siddique

@rabi-siddique
Copy link
Contributor Author

Let's not merge this. The latest version of @agoric/synpress fails for transaction signing popups. image

Are we fixing this then? @rabi-siddique

Yes. I will be inspecting this failure.

@rabi-siddique
Copy link
Contributor Author

Merging. Will inspect the local failures with chrome and create a separate PR for fix.

@rabi-siddique rabi-siddique merged commit 621d214 into main Dec 26, 2024
8 checks passed
@rabi-siddique rabi-siddique deleted the rs-update-agoric-synpress branch December 26, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants