Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add an integration job to CI #70

Merged
merged 1 commit into from
Mar 20, 2024
Merged

ci: add an integration job to CI #70

merged 1 commit into from
Mar 20, 2024

Conversation

LuqiPan
Copy link
Contributor

@LuqiPan LuqiPan commented Mar 20, 2024

Closes #48

@LuqiPan LuqiPan requested a review from dckc March 20, 2024 19:09
@LuqiPan LuqiPan marked this pull request as ready for review March 20, 2024 19:09
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion to consider

'
- name: yarn start:contract
run: yarn start:contract
- name: verify contracts started onchain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if this were part of yarn test:e2e above. not critical

@LuqiPan LuqiPan merged commit 0f7b3a2 into main Mar 20, 2024
2 checks passed
@LuqiPan LuqiPan deleted the 48-ci branch March 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci for getting started with dapp-offer-up, docker-compose
2 participants