Fix/UI noble hashes #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jovonni
force-pushed
the
fix/ui-noble-hashes
branch
from
3ea7159 to
ce101b9
Compare
Jovonni
commented
Aug 16, 2024
| export default defineConfig({ | ||
| plugins: [react()], | ||
| resolve: { |
There was a problem hiding this comment.
this is so the uI can resolve the noble hashes deps that the workspace defines
There was a problem hiding this comment.
I don't understand. I can't find any occurrences of @noble/hashes in the ui directory.
There was a problem hiding this comment.
its a sub-dependency from @cosmjs/proto-signing 🫠
✘ [ERROR] Could not resolve "@noble/hashes/sha3"
../node_modules/@cosmjs/proto-signing/node_modules/@cosmjs/crypto/build/keccak.js:4:23:
4 │ const sha3_1 = require("@noble/hashes/sha3");
╵ ~~~~~~~~~~~~~~~~~~~~
The module "./sha3.js" was not found on the file system:
../node_modules/@noble/hashes/package.json:116:17:
116 │ "require": "./sha3.js"
╵ ~~~~~~~~~~~First encountered here
dckc
reviewed
Aug 19, 2024
| make copy-bn-js | ||
| # make copy-bn-js |
| ADDR=agoric1mqvg26gpv6xzch2v0wpv569md3c2z4cdxq9clz | ||
| ADDR=agoric1jwuskhnxkjw50vnx3ak8qwmvy8f43sfdxnd438 |
| @@ -18,7 +18,8 @@ | |||
| "deploy": "make dev-working", | |||
| "test": "ava", | |||
| "lint": "tsc && eslint '**/*.js'", | |||
| "lint:fix": "eslint --fix '**/*.js'" | |||
| "lint:fix": "eslint --fix '**/*.js'", | |||
| "e2e": "make e2e" | |||
There was a problem hiding this comment.
this looks like a build commit, not a fix
| export default defineConfig({ | ||
| plugins: [react()], | ||
| resolve: { |
There was a problem hiding this comment.
I don't understand. I can't find any occurrences of @noble/hashes in the ui directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes noble hashes issue with ui.
Errors observed here:
#18 (comment)