docs: initial docs for chainhub #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying documentation with
|
| Latest commit: |
f2f4dd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c019d01b.documentation-7tp.pages.dev |
| Branch Preview URL: | https://rs-chainhub-documentation.documentation-7tp.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-chainhub-documentation
branch
from
d418451 to
071fea6
Compare
toliaqat
reviewed
Jul 9, 2024
|
|
||
| The core functionality is encapsulated within the `makeChainHub` function, which sets up a new `ChainHub` in the given zone. The `ChainHub` is responsible for: | ||
|
|
||
| ## **chainHub.registerChain(name, chainInfo)** |
There was a problem hiding this comment.
Either remove chainHub in all APIs or add to all of them.
I think for cleaner presentation you may just delete chainHub in all.
Also, because this is a heading, you may also delete the parameters. But I haven't seen at other pages to confirm what is the convention here.
There was a problem hiding this comment.
Adding chainHub with all APIs. Followed conventions from here
rabi-siddique
force-pushed
the
rs-chainhub-documentation
branch
from
6abeb9c to
d8056fe
Compare
chore: revert index.js and yarn.lock to older versions
rabi-siddique
force-pushed
the
rs-chainhub-documentation
branch
from
d8056fe to
f2f4dd7
Compare
dckc
requested changes
Jul 16, 2024
There was a problem hiding this comment.
This looks like reference docs.
Let's please get it in @agoric/orchestration reference docs instead, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR documents ChainHub API with code examples.
rendered:
refs