Add Blender texture graph fidelity#45
Conversation
📝 WalkthroughWalkthroughThis PR adds support for UV mapping and color-separation shader nodes in Blender and USD material workflows by enhancing socket type detection, extending renderer-specific node and parameter mappings, and validating the feature with comprehensive end-to-end tests. ChangesUV Mapping and Color Separation Feature
Sequence DiagramsequenceDiagram
participant BlenderTraverser
participant MappingTable
participant USDGraphBuilder
participant USDRenderer
BlenderTraverser->>BlenderTraverser: _socket_generic_type detects UV/separation socket
BlenderTraverser->>MappingTable: query REGULAR_NODE_TYPES_TO_GENERIC
MappingTable-->>BlenderTraverser: GENERIC::uvmap or GENERIC::separate_color
BlenderTraverser->>BlenderTraverser: extract parameters for identified node type
BlenderTraverser-->>USDGraphBuilder: NodeInfo with generic type
USDGraphBuilder->>MappingTable: _renderer_parm_name via REGULAR_PARAM_NAMES_TO_GENERIC
MappingTable-->>USDGraphBuilder: renderer-specific parameter names
USDGraphBuilder->>USDGraphBuilder: _connection_parm_name computes src/dst parameters
USDGraphBuilder->>USDRenderer: set_shader_connections with mapped parameters
USDRenderer->>MappingTable: GENERIC_NODE_TYPES_TO_REGULAR_USD lookup
MappingTable-->>USDRenderer: USD Shader prim info_id
USDRenderer->>USDRenderer: create Shader nodes and wire connections
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Review Notes
Validation
Full local pytest result: 128 passed, 21 skipped, 1 xfailed.