Skip to content

Add Blender texcoord mapping value support#47

Merged
Ahmed-Hindy merged 1 commit into
mainfrom
codex/blender-texcoord-mapping-value
May 31, 2026
Merged

Add Blender texcoord mapping value support#47
Ahmed-Hindy merged 1 commit into
mainfrom
codex/blender-texcoord-mapping-value

Conversation

@Ahmed-Hindy

Copy link
Copy Markdown
Owner

Summary

  • add Blender ShaderNodeTexCoord UV-only support by reusing GENERIC::uvmap
  • add GENERIC::mapping and GENERIC::value paths for Blender traversal/recreation and USD MaterialX/OpenPBR emission
  • emit mapping/value nodes as ND_place2d_vector2 and ND_constant_float, with tests for Blender graph standardization and USD connections

Why

The real Blender scene mo_sh_001_lighting_v005.blend exposed ShaderNodeMapping, ShaderNodeTexCoord, and ShaderNodeValue as unsupported/null nodes in Marble.012. MaterialX has standard equivalents for this UV mapping slice, so those nodes should survive ingestion and USD conversion instead of being dropped.

Validation

  • uv --native-tls run pytest tests/test_blender_support.py tests/test_usd_json_conversion.py
  • uv --native-tls run pytest
  • Headless Blender 4.5 validation on G:\Projects\AYON_PROJECTS\mo_ashraf\Mojar_01\sh_001\work\lighting\mo_sh_001_lighting_v005.blend: 11/11 node materials read and wrote successfully; Marble.012 now reports unsupported_count: 0.

Remaining limitations

  • Blender ShaderNodeGroup is still unsupported for felt_fabric_03 and old_gold_04.
  • The scene still references two missing external BlenderKit textures under C:\PROJECT\BlenderKit\SCENES\Minimalist podium in front of rocks\Marble\.

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Ahmed-Hindy, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10d736fe-d40b-41cc-a80c-a8163b573086

📥 Commits

Reviewing files that changed from the base of the PR and between a5cdcec and 8b09d44.

📒 Files selected for processing (7)
  • src/materials_processor/dcc/blender/recreator.py
  • src/materials_processor/dcc/blender/traverser.py
  • src/materials_processor/mappings.py
  • src/materials_processor/usd/graph_builder.py
  • src/materials_processor/usd/mappings.py
  • tests/test_blender_support.py
  • tests/test_usd_json_conversion.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/blender-texcoord-mapping-value

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ahmed-Hindy
Ahmed-Hindy marked this pull request as ready for review May 31, 2026 11:12
@Ahmed-Hindy Ahmed-Hindy changed the title [codex] Add Blender texcoord mapping value support Add Blender texcoord mapping value support May 31, 2026
@Ahmed-Hindy Ahmed-Hindy self-assigned this May 31, 2026
@Ahmed-Hindy
Ahmed-Hindy merged commit e0a8cd1 into main May 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant