Add Blender texcoord mapping value support#47
Conversation
|
Warning Review limit reached
More reviews will be available in 15 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ShaderNodeTexCoordUV-only support by reusingGENERIC::uvmapGENERIC::mappingandGENERIC::valuepaths for Blender traversal/recreation and USD MaterialX/OpenPBR emissionND_place2d_vector2andND_constant_float, with tests for Blender graph standardization and USD connectionsWhy
The real Blender scene
mo_sh_001_lighting_v005.blendexposedShaderNodeMapping,ShaderNodeTexCoord, andShaderNodeValueas unsupported/null nodes inMarble.012. MaterialX has standard equivalents for this UV mapping slice, so those nodes should survive ingestion and USD conversion instead of being dropped.Validation
uv --native-tls run pytest tests/test_blender_support.py tests/test_usd_json_conversion.pyuv --native-tls run pytestG:\Projects\AYON_PROJECTS\mo_ashraf\Mojar_01\sh_001\work\lighting\mo_sh_001_lighting_v005.blend:11/11node materials read and wrote successfully;Marble.012now reportsunsupported_count: 0.Remaining limitations
ShaderNodeGroupis still unsupported forfelt_fabric_03andold_gold_04.C:\PROJECT\BlenderKit\SCENES\Minimalist podium in front of rocks\Marble\.