Skip to content

Add Rush support (for monorepos)#382

Merged
reiniercriel merged 19 commits into
AikidoSec:mainfrom
mcmeeking:feature/add-rush-monorepo-support
May 12, 2026
Merged

Add Rush support (for monorepos)#382
reiniercriel merged 19 commits into
AikidoSec:mainfrom
mcmeeking:feature/add-rush-monorepo-support

Conversation

@mcmeeking
Copy link
Copy Markdown
Contributor

@mcmeeking mcmeeking commented Apr 2, 2026

Summary

Adds support for Microsoft's Rush (used for monorepos).

Changes

  • New CLI wrappers: aikido-rush and aikido-rushx
  • Registers Rush in package manager initialisation
  • Implements Rush command runner with proxy env normalisation
  • Adds dependency pre-scan support for rush add (package extraction & version resolution)
  • Includes Rush in shell integration tool mappings and CI shim coverage
  • Updates README and CLI help text to list Rush as a supported package manager
  • Adds Rush-focused tests

Closes

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

🚀 New Features

  • Added Rush and Rushx monorepo package manager support and tests

More info

Copy link
Copy Markdown
Collaborator

@reiniercriel reiniercriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the contribution! Left a few comments here.

Comment thread packages/safe-chain/src/packagemanager/rush/runRushCommand.js Outdated
Comment thread packages/safe-chain/src/packagemanager/rush/runRushCommand.js Outdated
Comment thread packages/safe-chain/src/packagemanager/rush/createRushPackageManager.js Outdated
Comment thread packages/safe-chain/src/packagemanager/rush/runRushCommand.spec.js
Comment thread packages/safe-chain/src/packagemanager/rush/createRushPackageManager.js Outdated
@mcmeeking mcmeeking requested a review from reiniercriel May 8, 2026 12:14
mcmeeking added 2 commits May 12, 2026 10:33
Incorporates the actual Rush and PNPM versions instead of pinning an old known-good version of PNPM
@mcmeeking
Copy link
Copy Markdown
Contributor Author

@reiniercriel, I've added a util which resolves the failures (due to Rush's requirement that specific semver versions are used in the rush.json config). Expecting fails on Node 18 and 20 still until the changes from #453 are merged, but should be fine after that.

@reiniercriel
Copy link
Copy Markdown
Collaborator

@reiniercriel, I've added a util which resolves the failures (due to Rush's requirement that specific semver versions are used in the rush.json config). Expecting fails on Node 18 and 20 still until the changes from #453 are merged, but should be fine after that.

Hi @mcmeeking #453 was merged, can you merge main into your branch, that should hopefully resolve the remaining issues!

@mcmeeking
Copy link
Copy Markdown
Contributor Author

@reiniercriel, thanks - merged now. I had to add a --safe-chain-skip-minimum-package-age to the test run as it was catching Rush's PNPM bootstrap of pnpm@11.1.0 😅

Should be good to go now.

@reiniercriel
Copy link
Copy Markdown
Collaborator

@mcmeeking looks like one little change will be needed still for "safe-chain proxy blocks malicious package downloads during rush update", for a couple of Node versions. Test works fine but I think the expected output is a little different than what is actually shown.

Count is apparently not deterministic
@mcmeeking
Copy link
Copy Markdown
Contributor Author

@mcmeeking looks like one little change will be needed still for "safe-chain proxy blocks malicious package downloads during rush update", for a couple of Node versions. Test works fine but I think the expected output is a little different than what is actually shown.

@reiniercriel - got it this time I think, just making it a generic digit match to avoid flakes moving forward.

@reiniercriel reiniercriel merged commit 0c8de1e into AikidoSec:main May 12, 2026
19 checks passed
@reiniercriel
Copy link
Copy Markdown
Collaborator

Thanks @mcmeeking ! I'll talk to the team and will try to make a release today or tomorrow.

@mcmeeking
Copy link
Copy Markdown
Contributor Author

Awesome, thanks for your help getting it merged!

@mcmeeking mcmeeking deleted the feature/add-rush-monorepo-support branch May 12, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants