Add Rush support (for monorepos)#382
Conversation
Co-authored-by: Copilot <copilot@github.com>
reiniercriel
left a comment
There was a problem hiding this comment.
Hi thanks for the contribution! Left a few comments here.
Note: rushx only dispatches package.json scripts, so it's probably not necessary to add it as a distinct manager at all.
Incorporates the actual Rush and PNPM versions instead of pinning an old known-good version of PNPM
|
@reiniercriel, I've added a util which resolves the failures (due to Rush's requirement that specific semver versions are used in the |
Hi @mcmeeking #453 was merged, can you merge main into your branch, that should hopefully resolve the remaining issues! |
|
@reiniercriel, thanks - merged now. I had to add a Should be good to go now. |
|
@mcmeeking looks like one little change will be needed still for "safe-chain proxy blocks malicious package downloads during rush update", for a couple of Node versions. Test works fine but I think the expected output is a little different than what is actually shown. |
Count is apparently not deterministic
@reiniercriel - got it this time I think, just making it a generic digit match to avoid flakes moving forward. |
|
Thanks @mcmeeking ! I'll talk to the team and will try to make a release today or tomorrow. |
|
Awesome, thanks for your help getting it merged! |
Summary
Adds support for Microsoft's Rush (used for monorepos).
Changes
aikido-rushandaikido-rushxrush add(package extraction & version resolution)Closes
Summary by Aikido
🚀 New Features
More info