[Aikido] Fix 8 security issues in node-forge, @isaacs/brace-expansion, minimatch#416
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade node-forge to fix certificate chain validation bypass, signature forgery, DoS attacks, and Ed25519 malleability; upgrade @isaacs/brace-expansion to fix exponential expansion DoS.
✅ The node-forge upgrade from 1.3.2 to 1.4.0 does not introduce breaking changes that affect this codebase.
The codebase uses node-forge in
packages/safe-chain/src/registryProxy/certUtils.jsfor:Generating RSA key pairs (
forge.pki.rsa.generateKeyPair)Creating and signing certificates (
cert.sign())Converting certificates and keys to/from PEM format
Setting certificate extensions including
basicConstraintsNone of the breaking changes in version 1.4.0 affect this usage:
BigInteger.modInverse(): Not used in the codebaseRSA PKCS#1 v1.5 signature verification: The code only signs certificates, it does not verify signatures
Ed25519 signature verification: Not used in the codebase
pki.verifyCertificateChain(): Not used in the codebaseThe code generates certificates with proper
basicConstraintsextension (already present ingenerateCa()function), so the stricter validation in certificate chain verification would not cause issues even if that function were used.All breaking changes by upgrading node-forge from version 1.3.2 to 1.4.0 (CHANGELOG)
BigInteger.modInverse()now exits early with zero when the target object value is <= 0, instead of entering an infinite looppki.verifyCertificateChain()now rejects certificate chains where intermediate certificates lackbasicConstraintsextension✅ 8 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
*()and+()) generate regexps with catastrophic backtracking, causing severe ReDoS denial-of-service attacks with minimal input patterns triggering multi-second hangs.🔗 Related Tasks