[Aikido] Fix 6 security issues in lodash, diff, picomatch#42
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
[Aikido] Fix 6 security issues in lodash, diff, picomatch#42aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade lodash, diff, and picomatch to fix critical remote code execution vulnerabilities in template compilation and prototype pollution attacks.
✅ Code not affected by breaking changes.
✅ No breaking changes from lodash 4.18.0 affect this codebase.
The codebase uses
_.template()inaws-test/tint.js(line 115), but it does not pass animportsoption to the method - it only configures_.templateSettings.interpolateand calls_.template(templateSrc)with a single argument. The breaking change regardingimportsvalidation does not apply.The methods
_.unset()and_.omit()are not used anywhere in the codebase.All breaking changes by upgrading lodash from version 4.17.21 to 4.18.0 (CHANGELOG)
_.unset/_.omitnow blockconstructorandprototypeas non-terminal path keys unconditionally. Calls that previously returnedtrueand deleted the property now returnfalseand leave the target untouched._.templatenow throws"Invalid imports option passed into _.template"whenimportskeys contain forbidden identifier characters, which were previously allowed.✅ 6 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
parsePatchandapplyPatchmethods are vulnerable to denial-of-service attacks when processing patches with specific line break characters (\r,\u2028,\u2029) in filename or patch headers, causing infinite loops and memory exhaustion or ReDoS attacks.🔗 Related Tasks