security updates #3821
Closed
security updates #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SEMVER-3247795
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PLATFORMIO-5665553 - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-3319937 - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-5538332
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PLATFORMIO-5665553 - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-3319937 - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-5538332
…cc5b849cb [Snyk] Fix for 3 vulnerabilities
…918675684 [Snyk] Fix for 3 vulnerabilities
…07561121c [Snyk] Security upgrade nodemon from 2.0.20 to 3.0.0
Snyk has created this PR to upgrade nodemon from 3.0.0 to 3.0.3. See this package in npm: https://www.npmjs.com/package/nodemon See this project in Snyk: https://app.snyk.io/org/farmmanic/project/1cc176a7-ec8b-4b8c-b8fc-6c54d89879b0?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade clean-css from 4.2.3 to 4.2.4. See this package in npm: https://www.npmjs.com/package/clean-css See this project in Snyk: https://app.snyk.io/org/farmmanic/project/1cc176a7-ec8b-4b8c-b8fc-6c54d89879b0?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Hi, could you explain a bit about the background of this change? Is it the result of |
|
I setup some ci/cd security workflows. I only pushed the dependacies so
far. I did audit the binaries. Cant automate those fixes yet. I'll setup
the pio auto build workflow later today. I'll be doing some other
automation lmk if you have any requirements.
…On Thu, Mar 14, 2024, 3:06 PM Frank ***@***.***> wrote:
Hi, could you explain a bit about the background of this change? Is it the
result of npm audit fix, or where do the changes come from? Maybe you did
a penetration test?
Did you verify the modifications by test?
—
Reply to this email directly, view it on GitHub
<#3821 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY3AXXQK5NW3XCFM7BGI2Y3YYHYMBAVCNFSM6AAAAABEUM5X46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGE3TEOBYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…2842452404294 [Snyk] Upgrade clean-css from 4.2.3 to 4.2.4
…22360363e04e9 [Snyk] Upgrade nodemon from 3.0.0 to 3.0.3
|
Please follow this article. |
|
I'm setting up ci/cd stuff today whatever you guys want. I have it set now
to update my fork. Then merge. Then I run the pio autobuild action before
It sends the pr.
I didn't think it would matter for the version upgrades but I was gonna
reach out before I sent any code altering pr.
Do you have a preferred branch you want me to send from/to?
…On Fri, Mar 15, 2024, 2:29 AM Blaž Kristan ***@***.***> wrote:
Please follow this
<https://github.com/Aircoookie/WLED/wiki/How-to-properly-submit-a-PR>
article.
—
Reply to this email directly, view it on GitHub
<#3821 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY3AXXWHBSG6WS5NKQOMED3YYKIMLAVCNFSM6AAAAABEUM5X46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGAZDEMZZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
sorry i didn't realize it was pushing everything. should have only pushed pr that i verified. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
edited snyk-security.yml
…hema-and-jsprim-0.4.0 Bump json-schema and jsprim
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PLATFORMIO-5665553 - https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-3319937
…9e72108c6c [Snyk] Fix for 2 vulnerabilities
|
|
You can delete this.
I'm sorry about that I was using scrips and testing automations. They went
a little off the rails.
…On Mon, Mar 18, 2024, 7:24 PM Frank ***@***.***> wrote:
@farmmanic <https://github.com/farmmanic>
- please remove any 'linter' that cannot check C, C++ or JavaScript.
There is no python in the final WLED image, so we don't need python
checkers like pylint or bandit or snyk.
- you propose to add some workflows that use "actions that are not
certified by GitHub.". Please explain the purpose and added value of these
actions.
—
Reply to this email directly, view it on GitHub
<#3821 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY3AXXXLPRFLTN3OVZTLL7LYY5ZSXAVCNFSM6AAAAABEUM5X46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGI4DINZQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @farmmanic I still find parts of your changes interesting, however as you say a lot of cleanup would be needed to extract the "usefull parts". As suggested by @blazoncek I'd also prefer if you make a fresh PR.
I'm closing this PR for now, hoping you'll find time to clean up your very interesting contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.