Support DDP sources that don't PUSH #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source never sends the push flag, WLED buffers the update but never publishes it to the LEDs. This causes the confusing case where the peek display shows one thing but the LEDs themselves something else. Add a static flag that tracks if we've seen a push from the source; until we do, apply every update as soon as it's received, per the DDP specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WLED was depending on the DDP PUSH flag to indicate when to push the updated LED colors to the hardware. However, use of this flag is technically optional in the DDP protocol. This patch adds support non-pushing sources by applying updates immediately until a PUSH is received (thereby indicating that the source does, in fact, want some kind of synchronization).
This was discovered somewhat accidentally by @bigredfrog (holidayhero on Discord) as a bug in LEDFX was preventing them from sending the PUSH flag in some cases. This resulted in the counterintuitive behavior of "peek" showing the updated colors, but the actual physical LEDs remaining frozen.