Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSD1309_64 I2C Support for FLD Usermod #3836

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

THATDONFC
Copy link
Contributor

Adds support for SSD1309_64 I2C display to the FLD Usermod.

Fixes an issue where palettes with an ID > 58 but not a custom palette did not display the palette name on the display.

There are quite a bit of whitespace diffs caused by trailing spaces being removed before commit.

Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid breaking changes if possible. Even at the expense of awkward UI order if necessary (but I think it will be ok).

@THATDONFC
Copy link
Contributor Author

THATDONFC commented Mar 20, 2024

I would avoid breaking changes if possible. Even at the expense of awkward UI order if necessary (but I think it will be ok).

Got it. So move the new display to the end of the list and make it # 9 and change the existing ones back to their original values?

My OCD is going to hate that but I understand wanting to avoid breaking changes wherever possible.

@blazoncek
Copy link
Collaborator

Yes. Thank you.
And I completely understand your feelings as well.

@THATDONFC
Copy link
Contributor Author

This should revert the breaking change. Let me know if you want me to move the new display to the end of the list in each place I added it. I think this is a good compromise to keep the UI order organized while retaining backwards compatibility.

@blazoncek blazoncek merged commit 3c23672 into Aircoookie:0_15 Mar 21, 2024
3 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants